[PS-2242] Quotes break adminSettings__admins

[danepowell]

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Setting up the unified server, I copied the default settings.env and changed the adminSettings__admins string to a single email address in quotes:
#adminSettings__admins="admin1@example.com"

But when trying to log into the admin panel, BW never sent me an email. Removing the quotes fixed the issue. Since this is the only example setting with quotes, I have to think that they are not supposed to be there.

Code changes

• settings.env: Remove quotes from adminSettings__admins

Before you submit

• Please check for formatting errors (dotnet format --verify-no-changes) (required)
• If making database changes - make sure you also update Entity Framework queries and/or migrations
• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PS-2242

[kspearrin]

I think quotes were added because of the commas and possibility of people adding spaces. How do we escape the possibility of spaces in this value?

[ghost]

There is no problem using whitespace in env files/variables.
Only the admin service must handle/ignore them correctly when parsing the env variable.