Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-894] Increase secret value max limit #3193

Merged
merged 6 commits into from
Aug 28, 2023
Merged

[SM-894] Increase secret value max limit #3193

merged 6 commits into from
Aug 28, 2023

Conversation

Thomas-Avery
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [X] Other

Objective

The purpose of this PR is to increase the max length limit of secret values.

Code changes

  • src/Api/SecretsManager/Models/Request/SecretCreateRequestModel.cs:
    Increase limit.

  • src/Api/SecretsManager/Models/Request/SecretUpdateRequestModel.cs:
    Increase limit.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Thomas-Avery Thomas-Avery self-assigned this Aug 14, 2023
@bitwarden-bot
Copy link

bitwarden-bot commented Aug 14, 2023

Logo
Checkmarx One – Scan Summary & Details311a66d2-6e83-4009-8cfc-c9e4effb6c10

No New Or Fixed Issues Found

@Thomas-Avery Thomas-Avery marked this pull request as ready for review August 15, 2023 20:31
@Thomas-Avery Thomas-Avery requested a review from a team as a code owner August 15, 2023 20:31
@Thomas-Avery Thomas-Avery merged commit 7cac93e into master Aug 28, 2023
46 checks passed
@Thomas-Avery Thomas-Avery deleted the sm/sm-894 branch August 28, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants