Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ComposeVersion from template #3972

Conversation

mimartin12
Copy link
Contributor

@mimartin12 mimartin12 commented Apr 10, 2024

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes bitwarden/self-host#232
Version is completely optional for docker compose and in the newest version is being labeled as obsolete.

04-version-and-name.md

Code changes

Simply removes the ComposeVersion string and the templating for it that creates the Docker Compose file.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.50%. Comparing base (3cdfbdb) to head (b93ce84).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   37.50%   37.50%           
=======================================
  Files        1179     1179           
  Lines       57221    57221           
  Branches     5490     5490           
=======================================
  Hits        21463    21463           
  Misses      34746    34746           
  Partials     1012     1012           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details46ee358e-b24c-4e3d-bf70-11e52269b883

No New Or Fixed Issues Found

@mimartin12 mimartin12 requested a review from a team April 11, 2024 16:30
@mimartin12 mimartin12 merged commit 122d1b7 into main Apr 15, 2024
50 checks passed
@mimartin12 mimartin12 deleted the DEVOPS-1895-docker-compose-version-2-25-0-now-reports-that-version-is-obsolete branch April 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"WARN docker-compose.yml: version is obsolete" when starting or stopping bitwarden
2 participants