Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send upcoming invoice to provider billing email #4112

Conversation

cyprain-okeke
Copy link
Contributor

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Provider Upcoming Invoice Notification

We need to send an email notification to the provider's billing email when an invoice is upcoming. This will ensure that the provider is aware of any upcoming charges and can choose to manage their billing information accordingly.

When an invoice.upcoming event is received, we need to retrieve the associated provider's billing email from the subscription's metadata.
we need to generate an email notification that includes the details of the upcoming invoice.
we need to send this email notification to the provider's billing email to alert them of the upcoming invoice

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
@cyprain-okeke cyprain-okeke requested a review from a team as a code owner May 21, 2024 15:28
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 39.06%. Comparing base (f224218) to head (d9a0287).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Billing/Controllers/StripeController.cs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4112      +/-   ##
==========================================
- Coverage   39.07%   39.06%   -0.01%     
==========================================
  Files        1201     1201              
  Lines       58021    58033      +12     
  Branches     5339     5341       +2     
==========================================
  Hits        22670    22670              
- Misses      34295    34306      +11     
- Partials     1056     1057       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3bcafec4-1aa2-404d-9562-da52ef877cfe

No New Or Fixed Issues Found

Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet. Looks good!

@cyprain-okeke cyprain-okeke merged commit a9ab894 into main May 23, 2024
49 checks passed
@cyprain-okeke cyprain-okeke deleted the ac-2380-as-a-billing-system-I-need-to-send-an-upcoming-invoice-email-notification branch May 23, 2024 10:40
withinfocus pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants