-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRE-87 Add enable feature for upcoming release version Slack notifications #4122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4122 +/- ##
=======================================
Coverage 39.31% 39.31%
=======================================
Files 1210 1210
Lines 58335 58335
Branches 5369 5369
=======================================
Hits 22934 22934
- Misses 34320 34321 +1
+ Partials 1081 1080 -1 ☔ View full report in Codecov by Sentry. |
Eeebru
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add a new parameter to whether to send a notification for upcoming releases, which must be disabled by default.
Tested in: https://github.com/bitwarden/server/actions/runs/9211360311/job/25340552250
Related PR: https://github.com/bitwarden/devops/pull/2329
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)