-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2775] Show Teams Starter option in Bitwarden Portal #4187
Merged
cturnbull-bitwarden
merged 2 commits into
main
from
billing/AC-2775/teams-starter-option
Jun 21, 2024
Merged
[AC-2775] Show Teams Starter option in Bitwarden Portal #4187
cturnbull-bitwarden
merged 2 commits into
main
from
billing/AC-2775/teams-starter-option
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
โฆ if user is on that plan
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4187 +/- ##
=======================================
Coverage 40.60% 40.60%
=======================================
Files 1232 1232
Lines 59518 59518
Branches 5470 5470
=======================================
Hits 24170 24170
Misses 34208 34208
Partials 1140 1140 โ View full report in Codecov by Sentry. |
addisonbeck
approved these changes
Jun 15, 2024
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
โฆ if user is on that plan (#4187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐๏ธ Tracking
https://bitwarden.atlassian.net/browse/AC-2775
๐ Objective
For organizations on the "teams starter" plan, they seeing their plan in the Bitwarden Portal shown as "Free" instead. This is because we previously removed the teams starter option, so it falls back to "Free."
This PR ensures that the Teams Starter option displays if the org is on that plan type.
๐ธ Screenshots
โฐ Reminders before review
๐ฆฎ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or โน๏ธ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or ๐ญ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or โป๏ธ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes