Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Families Sponsorship Null Reference Exception #4194

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

cturnbull-bitwarden
Copy link
Contributor

🎟️ Tracking

📔 Objective

Resolves a null reference exception when updating an organization's sponsorship when the sponsorship is null

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@cturnbull-bitwarden cturnbull-bitwarden requested a review from a team June 17, 2024 15:29
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.60%. Comparing base (b5241f1) to head (4c07eec).
Report is 2 commits behind head on main.

Files Patch % Lines
...e/Services/Implementations/StripePaymentService.cs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4194      +/-   ##
==========================================
- Coverage   40.60%   40.60%   -0.01%     
==========================================
  Files        1232     1232              
  Lines       59518    59521       +3     
  Branches     5470     5471       +1     
==========================================
  Hits        24170    24170              
- Misses      34208    34211       +3     
  Partials     1140     1140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cturnbull-bitwarden cturnbull-bitwarden merged commit 732ded5 into main Jun 17, 2024
49 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/families-sponsorship-bugs branch June 17, 2024 15:45
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb88aa867-c67c-4048-ac2d-e1a424207f27

No New Or Fixed Issues Found

withinfocus pushed a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants