[AC-2744] Add provider portal pricing for consolidated billing #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4210 +/- ##
=======================================
Coverage 41.02% 41.02%
=======================================
Files 1245 1245
Lines 59888 59899 +11
Branches 5484 5484
=======================================
+ Hits 24567 24573 +6
- Misses 34187 34192 +5
Partials 1134 1134 ☔ View full report in Codecov by Sentry. |
cturnbull-bitwarden
approved these changes
Jun 24, 2024
withinfocus
pushed a commit
that referenced
this pull request
Jul 9, 2024
* Expanded Teams and Enterprise plan with provider seat data * Updated provider setup process with new plan information * Updated provider subscription retrieval and update with new plan information * Updated client invoice report with new plan information * Fixed tests * Fix broken test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/AC-2744
📔 Objective
This PR adds new provider portal pricing for the Teams (Monthly) and Enterprise (Monthly) plan. Because so much of the existing feature's functionality is driven off of matching plan types, I opted for expanding the
PasswordManagerPlanFeaturesobject to includeStripeProviderPortalSeatPlanIdandProviderPortalSeatPriceproperties. Then, in any Consolidated Billing scenario where were have to create or update subscriptions or show prices, I used these values instead of the originalStripeSeatPlanIdandSeatPriceproperties. This significantly decreased the blast radius of the changes both onserverandclient.Companion PR: bitwarden/clients#9753
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes