SM-1227: Improved error messages on failures

[mzieniukbw]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1227

📔 Objective

Improve error messages on failures.

Changes:

• action.yml: Added default value to base_url, since the docs specifies that all required: false inputs needs a default value.
• src/main.ts:
  • access_token input is required - consistency with action.yml
  • Added error message from BitwardenClient.loginWithAccessToken response into the error handling.
  • Debug logging when GH Action runs in debug.
  • Refactoring
  • Unit Tests coverage
• src/parser.ts:
  • Added parsing error messages from various parsing error scenarios as part into error handling.
  • Unit Test coverage

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
  team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
  issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – 8a408a53-0c96-42f7-8f45-7cb499f56180

No New Or Fixed Issues Found

[Thomas-Avery]

Nice addition with the unit tests!

The scope of these changes and the scope of SM-1227 don't seem to match up.

It looks like this:

• Alters the action.yml and default values passed
• Changes multiple error message responses
• Adds the ability to have the SDK code execute in debug mode

With this, we will need to update the ticket and clarify in the QA notes what all has changed, so the testing covers the new changes.

When increasing the scope of the original ticket, I would advise caution and thinking about if it makes sense to be a separate effort.

[Thomas-Avery]

“Added default value to base_url, since the docs specifies that all required: false inputs needs a default value.”

What documentation are you referring to?

[mzieniukbw]

You are right, it's not required but there is a note: https://github.com/actions/toolkit/tree/main/packages/core#inputsoutputs
If required set to be false, the input should have a default value in action.yml.

[Thomas-Avery]

LGTM