Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1117] Rename service accounts to machine accounts #97

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

coltonhurst
Copy link
Member

@coltonhurst coltonhurst commented Apr 11, 2024

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Rename variants of "service accounts" to "machine accounts".

Steps

I did the following:

  • File rename changes
  • Ran npm ci
  • Ran npm run prettier && npm run lint
  • Ran npm test
  • Ran npm run bundle

@coltonhurst coltonhurst self-assigned this Apr 11, 2024
@coltonhurst coltonhurst requested a review from a team as a code owner April 11, 2024 02:28
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailse48ba97b-e385-45f4-8a53-a98a019f80f6

No New Or Fixed Issues Found

@coltonhurst coltonhurst changed the title SM-1117: Rename service accounts to machine accounts [SM-1117] Rename service accounts to machine accounts Apr 11, 2024
Copy link
Collaborator

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coltonhurst coltonhurst merged commit 1e61234 into main Apr 29, 2024
8 of 11 checks passed
@coltonhurst coltonhurst deleted the sm/sm-1117 branch April 29, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants