[PM-8873] Add pattern for deep iframe nesting for login items #161
+215
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprusik
commented
Jun 18, 2024
| sidebar_label: iframe (nested) | ||
| sidebar_position: 3 | ||
| description: two sibling iframed login forms nested within a series of inline frames (iframe) that will POST on submit. Intermediate depth can be specified with a query string param of `depth` and integer value (e.g. `depth=6`). Intermediate depth defaults to a value of "3". | ||
| unlisted: true |
There was a problem hiding this comment.
This will make the page available on a deployed instance, but it won't have a user path via nav or web search.
This will allow us to refine the case before publishing a user path to the page
cagonzalezcs
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-8873
📔 Objective
Add pattern for deep iframe nesting for login items
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes