This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Redefine cipher "share" to "move to organization" #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true.
In addition to the share term being misleading, the
fa-share-alt
icon implies a forking of the cipher item rather than transferring ownership.When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization" and the icon is changed to
fa-cube
, which is used to indicate a collection. The act of moving an item to an organization is denoted byfa-arrow-circle-o-right
rather thanfa-share-alt
.Screen Shots
Confirm move single item
Confirm move multiple items
Multiple items moved toast
#### New "Org Owned" indicator
#### Action menu
#### Bulk action menu