Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Redefine cipher "share" to "move to organization" #1039

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Conversation

MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Jun 17, 2021

Overview

The term "Share" is confusing to users because it implies maintaining ownership and control of a cipher while allowing others to access it as well. It also implies the ability to revoke access or to stop sharing -- neither of these things is true.

In addition to the share term being misleading, the fa-share-alt icon implies a forking of the cipher item rather than transferring ownership.

When a cipher is "shared" it is irrevocably taken over by an organization. This occurs for good cryptographic and security reasons. The better solution to this is to revise the communication around "sharing." To that end, this work changes the term "share" to "move to organization" and the icon is changed to fa-cube, which is used to indicate a collection. The act of moving an item to an organization is denoted by fa-arrow-circle-o-right rather than fa-share-alt.

Screen Shots

Confirm move single item

image

Confirm move multiple items

image

Multiple items moved toast

image

#### New "Org Owned" indicator

image

#### Action menu

image

#### Bulk action menu

image

@MGibson1 MGibson1 requested a review from a team June 17, 2021 14:16
@MGibson1 MGibson1 marked this pull request as draft June 17, 2021 14:16
@MGibson1 MGibson1 marked this pull request as ready for review June 18, 2021 12:22
@MGibson1 MGibson1 merged commit f8a7439 into master Jun 21, 2021
@MGibson1 MGibson1 deleted the change-share-term branch June 21, 2021 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants