Gut does not stop internal timer after callback.

[bitwes]

In some complex setups GUT it is possible to cause GUT to yield for less time than it is supposed to. _yielding_callback should call _yield_timer.stop().

[theludovyc]

I made a test on my project https://github.com/theludovyc/Rakugo/blob/a620421257fe4b64e8b084cd26e22b6e5ffb6b9f/Test/TestParser/TestAsk/TestAsk.gd#L12

It passed some times, but often failed.

yield_to never wait time in parameters, even if I set it to 5s. Always instant.

But if I wait the previous signal (like there https://github.com/theludovyc/Rakugo/blob/a620421257fe4b64e8b084cd26e22b6e5ffb6b9f/Test/TestParser/TestSay/TestSay.gd#L12), it never failed.

Can this bug cause that ?

[bitwes]

It's possible. You can try the workarounds below to see if it makes the test consistent. I looked back at the code to try and figure out what "complex setups" means, and I can't think of a valid example of when this will happen. I'm sure this is a bug, probably, but I don't know what I found when I made this issue.

You can stop the timer after each test so that the time remaining does not leak into the next test.

func after_each():
    gut._yield_timer.stop()

If you have multiple calls to yield_to in a single test, then you can call gut._yield_timer.stop() after each call to yield_to.

[theludovyc]

I have no problem between test.

Perhaps I expressed myself badly. With a picture it might be better

In second case, yield_to never wait time in parameters, even if I set it to 5s. Always instant.

[bitwes]

Fixed in godot_3x branch.

[theludovyc]

Thank you 😊