Optimize PNG images using oxipng and format files for POSIX compliance #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. They moved the "ignore whitespace" button which was holding me up on reviewing this. I also discovered that Godot has a trim whitespace option which makes these changes maintainable. I'll take another look at this and merge it this week. |
bitwes
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I losslessly optimized all of the PNG images in this repo with the command
oxipng -o6 --strip all --zopfli --fix. This reduces the files size of the images but does not affect the pixels.The second commit of this PR formats the files for POSIX compliance. I also updated the
.gitattributesfile to tell Git to set line endings correctly, and updated the.gitignorefile to be future-proof for Godot 4.