Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0 ShortcutButton Keycode Usage & Name Changes #396

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

Tim-Fronsee
Copy link
Contributor

Summary

Fixes

  • uid warning referencing play icon in GutBottomPanel by removing it to match other resources
  • Errors in ShortcutButton relating to renaming scancode to keycode in 4.0, and uses the get_keycode_with_modifiers function to parse the modifier.
  • Errors relating to 4.0 name changes in DirectoryCtrl::_init

Copy link
Owner

@bitwes bitwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_dialog.unresizable = false is just gross. Thanks.

@bitwes bitwes merged commit 955e0b2 into bitwes:4_0_experiments Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants