Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use project's launch config for port and address #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ali-wallick
Copy link

Using the commands for running tests with the debugger was broken with our project. Looking into it, I think the issue is currently the VSCode extension uses the LSP port.

With this PR, I'm instead pulling the port from the workspace's launch config. To be honest I am not familiar with TypeScript or developing extensions so this change was made with the help of AI. So I'm not super confident on this specific implementation, but it seems to resolve the issue in our project.

Thanks so much for the addon and extension, super excited to use it with our project!

@bitwes
Copy link
Owner

bitwes commented Apr 22, 2024

Thanks for the PR. I'm having some trouble determining the root cause of the issue, which I'd like to understand before merging in this code. Can you provide the following?

  • OS
  • GUT version
  • Godot version
  • Godot vscode plugin version
  • Your launch.json file.
  • Any errors or messages you are seeing.

The port should be getting pulled from the value configured in the Godot VSCode extension. I'm not 100% sure how launch.json works and would like to get the value from the Godot extension as this seems like a good source of truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants