strict type

.travis.yml

@@ -35,10 +35,10 @@ install:
 
 before_script:
 - sudo mysql_upgrade
-- travis_retry mysql -e 'CREATE DATABASE `podiumtest`;'
+- travis_retry mysql -e 'CREATE DATABASE `migrationtest`;'
 - mysql -e "SET GLOBAL sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION';"
-- mysql -e "CREATE USER 'podium'@'localhost' IDENTIFIED BY 'podium';"
-- mysql -e "GRANT ALL PRIVILEGES ON podiumtest.* TO 'podium'@'localhost';"
+- mysql -e "CREATE USER 'migration'@'localhost' IDENTIFIED BY 'migration';"
+- mysql -e "GRANT ALL PRIVILEGES ON migrationtest.* TO 'migration'@'localhost';"
 
 script:
 - vendor/bin/phpunit --verbose $PHPUNIT_FLAGS

Generator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration;
 
 use bizley\migration\table\TableColumn;

Updater.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration;
 
 use bizley\migration\table\TableChange;

composer.json

@@ -15,6 +15,7 @@
   },
   "require": {
     "php": ">=7.1.0",
+    "ext-mbstring": "*",
     "yiisoft/yii2": ">=2.0.15.1 <2.1.0"
   },
   "require-dev": {

controllers/MigrationController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\controllers;
 
 use bizley\migration\Generator;
@@ -22,13 +24,16 @@
  * Generates migration file based on the existing database table and previous migrations.
  *
  * @author Paweł Bizley Brzozowski
- * @version 3.0.0
+ * @version 3.0.2
  * @license Apache 2.0
  * https://github.com/bizley/yii2-migration
  */
 class MigrationController extends Controller
 {
-    protected $version = '3.0.0';
+    /**
+     * @var string
+     */
+    protected $version = '3.0.2';
 
     /**
      * @var string Default command action.
@@ -100,7 +105,7 @@ class MigrationController extends Controller
     /**
      * @var bool|string|int Whether to use general column schema instead of database specific.
      * Alias -g
-     * Since 2.3.0 this property is 1 by default.
+     * Since 3.0.0 this property is 1 by default.
      * @since 2.0
      */
     public $generalSchema = 1;
@@ -369,7 +374,7 @@ public function actionCreate($table): int
 
     /**
      * Creates new migrations for every table in database.
-     * Since 2.3.0 migration history table is skipped.
+     * Since 3.0.0 migration history table is skipped.
      * @return int
      * @since 2.1
      */
@@ -384,10 +389,10 @@ public function actionCreateAll(): int
 
         $confirm = $this->confirm(' > Are you sure you want to generate ' . \count($tables) . ' migrations?', false);
         if ($confirm) {
-            $this->actionCreate(implode(',', $tables));
-        } else {
-            $this->stdout("Operation cancelled by user.\n\n", Console::FG_YELLOW);
+            return $this->actionCreate(implode(',', $tables));
         }
+
+        $this->stdout("Operation cancelled by user.\n\n", Console::FG_YELLOW);
         return ExitCode::OK;
     }
 
@@ -430,7 +435,7 @@ public function actionUpdate($table): int
 
     /**
      * Creates new update migrations for every table in database.
-     * Since 2.3.0 migration history table is skipped.
+     * Since 3.0.0 migration history table is skipped.
      * @return int
      * @since 2.1
      */
@@ -445,18 +450,18 @@ public function actionUpdateAll(): int
 
         $confirm = $this->confirm(' > Are you sure you want to potentially generate ' . \count($tables) . ' migrations?', false);
         if ($confirm) {
-            $this->actionUpdate(implode(',', $tables));
-        } else {
-            $this->stdout("Operation cancelled by user.\n\n", Console::FG_YELLOW);
+            return $this->actionUpdate(implode(',', $tables));
         }
+
+        $this->stdout("Operation cancelled by user.\n\n", Console::FG_YELLOW);
         return ExitCode::OK;
     }
 
     /**
      * Removes migration history table name from the tables list.
      * @param array $tables
      * @return array
-     * @since 2.3.0
+     * @since 3.0.0
      */
     public function removeMigrationTable($tables): array
     {

phpunit.xml

@@ -6,7 +6,7 @@
          convertWarningsToExceptions="true"
          stopOnFailure="false">
     <testsuites>
-        <testsuite name="Test Suite">
+        <testsuite name="Yii 2 Migration Test Suite">
             <directory>./tests</directory>
         </testsuite>
     </testsuites>

table/TableChange.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;

table/TableColumn.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;
@@ -198,9 +200,9 @@ public function isColumnAppendPK($schema): bool
      * @param TableStructure $table
      * @param bool $primaryKey
      * @param bool $autoIncrement
-     * @return string
+     * @return string|null
      */
-    public function prepareSchemaAppend($table, $primaryKey, $autoIncrement): string
+    public function prepareSchemaAppend($table, $primaryKey, $autoIncrement): ?string
     {
         switch ($table->schema) {
             case TableStructure::SCHEMA_MSSQL:

table/TableColumnBigInt.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnBigPK.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnBigUPK.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnBinary.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnBoolean.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnChar.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnDate.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnDateTime.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnDecimal.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnDouble.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\InvalidConfigException;

table/TableColumnFloat.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnInt.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnJson.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnMoney.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnPK.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnSmallInt.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnString.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnText.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnTime.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnTimestamp.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnTinyInt.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableColumnUPK.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 /**

table/TableForeignKey.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;

table/TableIndex.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;

table/TablePlan.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;

table/TablePrimaryKey.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;

table/TableStructure.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace bizley\migration\table;
 
 use yii\base\BaseObject;