Replace SignInModel & ChangeNotifier with ValueNotifier<bool> #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizz84
changed the title
bizz84
added a commit
that referenced
this pull request
Jun 8, 2019
* Start converting bloc implementation to changeNotifier * Replace EmailPasswordSignInBloc with EmailPasswordSignInManager. Use ChangeNotifier rather than Streams * Manager no longer holds on to the model * Update sign in flow to use model with ChangeNotifier * Rename variable * Rename bloc -> manager * Replace SignInModel & ChangeNotifier with ValueNotifier<bool> (#5) * Replace SignInModel with ChangeNotifier with ValueNotifier<bool> * Inject ValueNotifier into manager and widget * Move ValueListenableBuilder outside SignInPage * Fix tests * Inject EmailPasswordSignInModel into EmailPasswordSignInManager and EmailPasswordSignInPage * Cleanup * Add dispose method * Use model getter rather than widget.model * Merge EmailPasswordSignInManager into EmailPasswordSignInModel * Simplify SignInPageBuilder implementation * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.