Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button that selects sample markup to be copied #6

Merged
merged 1 commit into from
Jul 13, 2013
Merged

Add button that selects sample markup to be copied #6

merged 1 commit into from
Jul 13, 2013

Conversation

GeoffYoung
Copy link
Contributor

Should help with #4
screen shot 2013-07-12 at 8 02 56 pm

@cramdesign
Copy link

put the get the code button right beside the view source... no need to view source if you just want to copy the code. Only folks who will use this are those in the know... :)

@bjankord
Copy link
Owner

Thanks @GeoffYoung, I like the "Get the code" button inside the source block.

@cramdesign I see your point of having it outside of the source block, having it be quicker to copy the source. My thought with this though is the user may not see that text has been selected when they click the button if the source block is hidden. It's common for the copy source button to be inside the code block in the top right.

@GeoffYoung I'll test this some and plan on merging it in today. Thanks!

@cramdesign
Copy link

I see your point. I agree.

Sent from my iPhone

On Jul 13, 2013, at 9:32 AM, Brett Jankord notifications@github.com wrote:

Thanks @GeoffYoung, I like the "Get the code" button inside the source block.

@cramdesign I see your point of having it outside of the source block, having it be quicker to copy the source. My thought with this though is the user may not see that text has been selected when they click the button if the source block is hidden. It's common for the copy source button to be inside the code block in the top right.

@GeoffYoung I'll test this some and plan on merging it in today. Thanks!


Reply to this email directly or view it on GitHub.

bjankord added a commit that referenced this pull request Jul 13, 2013
Add button that selects sample markup to be copied
@bjankord bjankord merged commit 0175fb5 into bjankord:master Jul 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants