Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update max nesting rule #35

Merged
merged 2 commits into from Aug 28, 2018

Conversation

dbartholomae
Copy link
Contributor

This solves #33

@@ -107,6 +107,19 @@ $my-var: 10px;
color: #f00;
}

// Nesting Depth test
$colors: {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch this to the following:

$colors: (
  white: #fff
);

The current code introduces lint in the passing-test-cases.scss file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure how I missed this ^^'

Copy link
Owner

@bjankord bjankord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, 1 change needs to be addressed and then this is good to merge.

@bjankord bjankord merged commit 8859217 into bjankord:master Aug 28, 2018
damjack pushed a commit to damjack/stylelint-config-bemo that referenced this pull request Apr 2, 2019
* test(nesting-depth): test for allowing @each in nesting

* feat(nesting-depth): allow @each in nesting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants