Fix patterns for variables like "$x1" #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take for example the variable pattern:
^[_]?[a-z]+([a-z0-9-]+[a-z0-9]+)?$
.([a-z0-9-]+[a-z0-9]+)?
is not matched it allows an arbitrary number of lowercase alphabetic character with an optional underscore at the beginning.([a-z0-9-]+[a-z0-9]+)?
is matched it does also allow numerics and dashes after that (but no dash at the end). But it will only match if there are at least two of these characters.I assume this last bit is unintentional, as it prohibits variable names such as
$x1
while allowing$x
,$xs
, and$x10
. Apart from fixing that, I also removed some dispensable+
as I think that makes the patterns easier to understand.