Add support for reading volt or ampere #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Monarco supports reading either Volt or Ampere via the analog inputs. Switching between the two involves sending commands via the SDC to flip a resistor. This commit allows the user to control this when the library is initiated.
|
Thank you so much for this! Did not know that the Monarco also can measure current, I will merge this as soon as I have tested it on my setup :) |
|
Hi @bjarnekvae, I just stumbled across this old very PR - completely forgot about it. I no longer use the Monarco and don't really remember what the change does. You are welcome to just close this PR if you want. No reason to merge it for my sake. |
|
Thank you for the heads up! I have also stopped using the Monarco HAT as I do not have any relevant projects at the moment. I will however keep this PR so when I need to use the Monarco again I can merge your code. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for a great library!
I have made some extensions that I think might also help other users of the Python wrapper.
The Monarco supports reading either Volt or Ampere via the analog inputs. Switching between the two involves sending commands via the SDC to flip a resistor. This commit allows the user to control this when the library is initiated.
The default configuration is to measure Volt on both ain1 and ain2. The change should therefore not make any difference for existing users.
The commit has been tested against a controlled ampere and voltage source to make sure the measurements are correct even with the change.
This commit does not require any changes to the C library.