Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grpc instrumentation #153

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Grpc instrumentation #153

merged 6 commits into from
Feb 16, 2024

Conversation

bjartek
Copy link
Owner

@bjartek bjartek commented Feb 13, 2024

Closes #???

Description

For contributor use:

  • Targeted PR against main branch
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

Unit Test Results

260 tests  ±0   260 ✔️ ±0   45s ⏱️ ±0s
    6 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 52a34d9. ± Comparison against base commit 708c99c.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Feb 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7928276388

Details

  • -7 of 8 (12.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 73.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
transaction.go 0 3 0.0%
setup.go 1 5 20.0%
Totals Coverage Status
Change from base Build 7915731995: 0.02%
Covered Lines: 2374
Relevant Lines: 3210
💛 - Coveralls

@bjartek bjartek mentioned this pull request Feb 15, 2024
Closed
@bjartek bjartek merged commit 6e86330 into main Feb 16, 2024
5 checks passed
@bjartek bjartek deleted the grpc-instrumentation branch February 16, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjartek @coveralls