Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

MD improvements, client side warnings #195

Merged
merged 4 commits into from Apr 21, 2015
Merged

MD improvements, client side warnings #195

merged 4 commits into from Apr 21, 2015

Conversation

bjb568
Copy link
Owner

@bjb568 bjb568 commented Apr 18, 2015

Please test to make sure it works.

@thomas-daniels
Copy link
Collaborator

Error message, not sure if related to this:

/home/programfox/DevDoodle/node_modules/mongodb/lib/utils.js:97
    process.nextTick(function() { throw err; });
                                        ^
Error
    at Object. (/home/programfox/DevDoodle/node_modules/mongodb/node_modules/mongodb-core/lib/error.js:42:24)
    at Module._compile (module.js:462:26)
    at Object.Module._extensions..js (module.js:480:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:367:17)
    at require (module.js:386:17)
    at Object. (/home/programfox/DevDoodle/node_modules/mongodb/node_modules/mongodb-core/index.js:2:17)
    at Module._compile (module.js:462:26)
    at Object.Module._extensions..js (module.js:480:10)

@minitech
Copy link
Collaborator

Unclosed quotation marks still result in <q>; I don’t know whether that’s intentional.

"test
<q>test</q>

@bjb568
Copy link
Owner Author

bjb568 commented Apr 18, 2015

@ProgramFOX Huh… maybe try updating mongodb? I think there's a new version.

@bjb568
Copy link
Owner Author

bjb568 commented Apr 18, 2015

@minitech Yes, that's intentional, all formatting characters must be escaped outside of code and samp.

@thomas-daniels
Copy link
Collaborator

Eh, that explains it, I didn't start the MongoDB server...

@thomas-daniels
Copy link
Collaborator

***test*** says "illegal nesting of *", but it is valid: expected result = bold + italic

@bjb568
Copy link
Owner Author

bjb568 commented Apr 18, 2015

That's bad. I'm not sure how it should parse that. ***test *test** and ***test **test* require a different order of <em> and <strong> so it's not trivial to parse.

I'm wondering if we need to support it at all, since it could be abused to shout and two levels of emphasis are enough for most cases…

if (['code', 'samp'].indexOf(current[current.length - 1]) == -1) {
if (input[i] == '\\') span += input[++i].replace('^', '\u0001').replace('[', '\u0002');
else {
for (var l = 4; l >= 0; l--) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not from 3 to 1?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose 3 to 1 would work.

bjb568 added a commit that referenced this pull request Apr 21, 2015
MD improvements, client side warnings
@bjb568 bjb568 merged commit fe55595 into master Apr 21, 2015
@bjb568 bjb568 deleted the md-syntax-check branch April 21, 2015 03:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants