Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symfony 6.3 deprecation warnings in FactoryTrait.php #23

Merged
merged 2 commits into from Dec 15, 2023

Conversation

pathmissing
Copy link
Contributor

Replaces the @required annotation with the corresponding attribute in order to fix symfony 6.3 deprecation warnings.
This change introduces a BC break with PHP installations < 8.0.

Replaces the @required annotation with the corresponding attribute in order to fix symfony 6.3 deprecation warnings.
@J-Ben87
Copy link
Member

J-Ben87 commented Dec 14, 2023

Hi @pathmissing
Thanks for your contribution!

What would you think if, instead of removing the deprecated @required annotation, we added the #[Required] attribute?
That way the bundle would remain compatible with older PHP and Symfony versions, and the deprecation wouldn't be a (real) problem anymore.

If you are concerned about having third party deprecations in your project, you may consider setting the relevant env variable to SYMFONY_DEPRECATIONS_HELPER=max[direct]=0&quiet[]=indirect&quiet[]=other.

Co-authored-by: Benoit Jouhaud <J-Ben87@users.noreply.github.com>
@pathmissing
Copy link
Contributor Author

Sounds good to me 👍

@J-Ben87 J-Ben87 merged commit 0c08bec into bjd-php:master Dec 15, 2023
@J-Ben87
Copy link
Member

J-Ben87 commented Dec 15, 2023

Amazing, thanks! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants