Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multiple webhooks feature #217

Merged
merged 2 commits into from
Jul 13, 2022
Merged

feat: Add multiple webhooks feature #217

merged 2 commits into from
Jul 13, 2022

Conversation

simenandre
Copy link
Member

Adds a way to set multiple channels (webhooks) in configuration. Also replaces axios with node-fetch (in prepration to move to undici/native fetch).

fixes #160

Adds a way to set multiple channels (webhooks) in configuration. Also replaces axios with node-fetch (in prepration to move to undici/native fetch).

fixes #160
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #217 (da4f8f4) into main (47f9316) will decrease coverage by 1.06%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##              main     #217      +/-   ##
===========================================
- Coverage   100.00%   98.93%   -1.07%     
===========================================
  Files            4        4              
  Lines           94       94              
  Branches         8       10       +2     
===========================================
- Hits            94       93       -1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/constants.ts 100.00% <ø> (ø)
src/slack.module.ts 100.00% <ø> (ø)
src/slack.service.ts 97.95% <94.11%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f9316...da4f8f4. Read the comment docs.

@simenandre simenandre merged commit 5843539 into main Jul 13, 2022
@simenandre simenandre deleted the multiple-webhooks branch July 13, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question - Multiple Webhooks possible?
1 participant