Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Cannot set authorize endpoint state param #36

Closed
johnkors opened this issue Apr 27, 2020 · 3 comments
Closed

[Feature Request] Cannot set authorize endpoint state param #36

johnkors opened this issue Apr 27, 2020 · 3 comments

Comments

@johnkors
Copy link

Hi,

I see there's a onBeforeSignin function to use for storing data before signing in. In the OIDC standard there's already something for this - the state parameter. RPs set this on requests towards the authorize endpoint.

In oidc.js, this is done via :
mgr.signinRedirect({state:'some data'})
, where some data can be anything you put into it, url-encoded.

The signIn function of the authContext hides this API, though. Could you make the signIn function take an object that can be passed to the signinRedirect method of oidc.js?

@simenandre simenandre changed the title Cannot set authorize endpoint state param [Feature Request] Cannot set authorize endpoint state param Apr 27, 2020
@simenandre
Copy link
Member

Great idea! Absolutely, we'll add that in. 👍

github-actions bot pushed a commit that referenced this issue May 15, 2020
# [1.0.0-alpha.7](v1.0.0-alpha.6...v1.0.0-alpha.7) (2020-05-15)

### Bug Fixes

* Useless conditional ([6cf9dda](6cf9dda))
* Variable 'user' cannot be of type null ([0d8a0c3](0d8a0c3))

### Code Refactoring

* Improve createContext setup ([6b715f5](6b715f5))

### Features

* Add improved API layout ([1e3d66a](1e3d66a)), closes [#36](#36)
* add option to use signoutRedirect ([d2c4278](d2c4278))

### BREAKING CHANGES

* Typescript users might not expect the Context to be 'null'. Now you have to check
it.
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Aug 20, 2020
# 1.0.0 (2020-08-20)

### Bug Fixes

* Autosignin on expired user ([d5dce04](d5dce04))
* Fix withAuth export ([4e0e2e1](4e0e2e1))
* Package size and target ([b9c8205](b9c8205))
* Useless conditional ([6cf9dda](6cf9dda))
* Variable 'user' cannot be of type null ([0d8a0c3](0d8a0c3))

### Code Refactoring

* Improve createContext setup ([6b715f5](6b715f5))

### Features

* add client_secret ([151a494](151a494))
* Add improved API layout ([1e3d66a](1e3d66a)), closes [#36](#36)
* Add onBeforeSignIn hook ([e2f609e](e2f609e))
* add option to use signoutRedirect ([9ca3ada](9ca3ada))
* add option to use signoutRedirect ([d2c4278](d2c4278))
* Add responseType and scope properties ([e00454a](e00454a))
* Add withAuth higher order component ([9f2cea8](9f2cea8))
* First implementation ([071d311](071d311))
* re-export User and UserManager ([a2fdf39](a2fdf39))

### BREAKING CHANGES

* Typescript users might not expect the Context to be 'null'. Now you have to check
it.
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants