-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: testing + linting technical debt #945
Conversation
…m + jest-fail-on-console
…ent, and enable failures on console warnings
…t versions of testing-library/jest
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes. You can run |
3982bf5
to
44b7dfc
Compare
Codecov Report
@@ Coverage Diff @@
## main #945 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 1
Lines ? 84
Branches ? 33
========================================
Hits ? 84
Misses ? 0
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Also, void functions and Promise<void>'s resolve to undefined, so there is no purpose in returning at the end.
Also I think it's safe to remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this! 🚀
Basically just trying to get the validation environment in a healthy state. Lots of warnings lingering around as a result of half-completed updates, some misuse of types (or lack thereof), a number of dependencies that were badly in need of updating, and some of the necessary pain that comes as a result of finally updating them.
act()
helper, I moved them outside of it and removed the needlessawait waitFor
.any
types.BEGIN_COMMIT_OVERRIDE
refactor!: add types (#945)
BREAKING-CHANGE:
signIn
andsignOutRedirect
now has it's own types.feat: update + pin a key dependencies in use (#945)
fix: validation environment (#945)
END_COMMIT_OVERRIDE