Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When initially mounted, isLoading is never set to false #981

Closed
jamesdh opened this issue Mar 21, 2023 · 0 comments · Fixed by #982
Closed

When initially mounted, isLoading is never set to false #981

jamesdh opened this issue Mar 21, 2023 · 0 comments · Fixed by #982
Assignees
@jamesdh

Comments

@jamesdh
Copy link
Contributor

jamesdh commented Mar 21, 2023

When autoSignIn is disabled, isLoading never gets set to false after the AuthContext effects complete. This makes detecting when it is appropriate to manually initiate sign in difficult.
@jamesdh jamesdh self-assigned this Mar 21, 2023
jamesdh added a commit to jamesdh/oidc-react that referenced this issue Mar 21, 2023
@jamesdh
fix: isLoading should be set to false when the primary useEffect comp…
eb6a7eb 
…letes

Fixes bjerkio#981
@jamesdh jamesdh mentioned this issue Mar 21, 2023
Merged
jamesdh added a commit that referenced this issue Mar 21, 2023
@jamesdh
fix: isLoading has correct status when autoSignIn is disabled and use…
db28cdd 
…r is signed out (#982)

* fix: isLoading should be set to false when the primary useEffect completes

Fixes #981

* fix: dont set refreshed user unless mounted

Possibly fixes #980 but doubtful

* test: finish rendering before makign assertions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesdh jamesdh

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jamesdh