Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transform point and points #409

Merged
merged 9 commits into from Sep 16, 2023
Merged

add transform point and points #409

merged 9 commits into from Sep 16, 2023

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Aug 8, 2023

馃殌 Pull Request

Description

This PR extends the geovista.transform API to also support transform_point and transform_points, alongside the already existing transform_mesh function.

I've been building up to this PR for a long while, but it's the first step in opening up some of the core functionality to allow users the ability to manipulate meshes for more complex workflows, rather than just rendering them in a scene.

Test coverage:

  • geovista.transform.transform_point
  • geovista.transform.transform_points

@bjlittle bjlittle marked this pull request as draft August 8, 2023 14:01
@github-actions github-actions bot added type: testing Auto-labelled type: examples Auto-labelled for ex/*, example/* and examples/* branches type: enhancement Auto-labelled for feat/* and feature/* branches labels Aug 8, 2023
@bjlittle bjlittle added the breaking-change Auto-labelled for break/*, breaking/* and breaking-change/* branches label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #409 (76932b4) into main (cf2bb4d) will increase coverage by 0.55%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   85.25%   85.80%   +0.55%     
==========================================
  Files          62       64       +2     
  Lines        3363     3509     +146     
==========================================
+ Hits         2867     3011     +144     
- Misses        496      498       +2     
Files Changed Coverage 螖
src/geovista/bridge.py 61.11% <71.42%> (-0.17%) 猬囷笍
src/geovista/transform.py 55.66% <92.72%> (+37.47%) 猬嗭笍
src/geovista/crs.py 66.00% <100.00%> (+1.41%) 猬嗭笍
src/geovista/search.py 100.00% <100.00%> (酶)
tests/transform/test_transform_point.py 100.00% <100.00%> (酶)
tests/transform/test_transform_points.py 100.00% <100.00%> (酶)

@bjlittle bjlittle force-pushed the feat/transform-points branch 2 times, most recently from 0ed9ec9 to 66943a6 Compare September 11, 2023 21:41
@github-actions github-actions bot removed the type: examples Auto-labelled for ex/*, example/* and examples/* branches label Sep 15, 2023
@bjlittle bjlittle marked this pull request as ready for review September 15, 2023 22:31
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
@tkoyama010
Copy link
Collaborator

pre-commit.ci autofix

@bjlittle
Copy link
Owner Author

Awesome, thanks @tkoyama010 馃嵒

@bjlittle bjlittle merged commit 2e732c8 into main Sep 16, 2023
15 checks passed
@bjlittle bjlittle deleted the feat/transform-points branch September 16, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Auto-labelled for break/*, breaking/* and breaking-change/* branches scipy 2023 type: enhancement Auto-labelled for feat/* and feature/* branches type: testing Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants