Accept xy points in set color(s) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a solid change, since the conversion from hex to CIE colorspace is definitely going to be lossy. |
chmac
added a commit
to chmac/lightflow
that referenced
this pull request
Nov 8, 2019
This is dependent on a change I proposed which may or may not be merged: bjohnso5/hue-hacking-npm#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some weird issues with my lights immediately changing colour when I tried to read their xy values and set a very similar xy value. I dug into it a little and it looks like the issue is in the conversion of my xy values -> hex and then back to xy. As an alternative, I added a little tweak that accepts an
XYPointinstances directly, and skips the conversion if so.What do you think? Make sense to merge?
Tests still pass, but I haven't added any tests that explicitly check the XYPoint variant. It does work for me locally, but that's not saying much! :-)