Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"undefined" in file names in snapshots-win download directory #1988

Closed
gheja opened this issue Aug 1, 2018 · 4 comments
Closed

"undefined" in file names in snapshots-win download directory #1988

gheja opened this issue Aug 1, 2018 · 4 comments

Comments

@gheja
Copy link

gheja commented Aug 1, 2018

Not sure if intentional or not but some files have the winundefined suffix (i.e. Tiled-2018.07.13-winundefined.7z ) on https://update.mapeditor.org/snapshots-win/

@gheja gheja changed the title Tiled-*-winundefined.7z file names in snapshots-win "undefined" in file names in snapshots-win download directory Aug 1, 2018
@bjorn
Copy link
Member

bjorn commented Aug 1, 2018

Yeah, I noticed this as well but I did not find out why yet. Thanks for opening an issue about it, I should definitely look into this again.

@bjorn
Copy link
Member

bjorn commented Aug 15, 2018

I'm a little stumped on this, since the code generating those files names is pretty much identical between the archive and the installer, and the "undefined" only shows up on the archive:

https://github.com/bjorn/tiled/blob/e736570e9d5c5cbbc98dfae717b62f637afb85dd/dist/win/installer.qbs#L26-L33

https://github.com/bjorn/tiled/blob/e736570e9d5c5cbbc98dfae717b62f637afb85dd/dist/archive.qbs#L27-L41

Will need to do some testing on Windows...

@bjorn
Copy link
Member

bjorn commented Sep 16, 2018

Tried to reproduce it on Windows, but got "32" instead of "undefined". Maybe it's something that was fixed in Qbs 1.12, which I used whereas the builds on AppVeyor are currently done with Qbs 1.11.1.

@bjorn bjorn closed this as completed in 260d20b Sep 17, 2018
@bjorn
Copy link
Member

bjorn commented Sep 17, 2018

Yup, updating to the latest Qbs version fixed this long standing issue. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants