Fix macOS build #1405
Merged
Fix macOS build #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This raises the minimumQbsVersion to 1.5.2. In Qbs 1.5.2, osx was renamed to macos. This is a forward compatible change, as Qbs guarantees that macos is in the targetOS list if osx is.
|
Hmm, I need to ask AppVeyor to update their version of Qbs first. :-) I think we can actually drop this Many thanks in any case, for working towards fixing the Qbs build on macOS! |
|
Note that you can actually install Qbs from Chocolatey now, and we (read: me) maintain it ourselves so it's always up to date. Then you don't have to rely on whatever version is in AppVeyor's Qt Creator install. ;) |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This raises the minimumQbsVersion to 1.5.2. In Qbs 1.5.2, osx was
renamed to macos. This is a forward compatible change, as Qbs guarantees
that macos is in the targetOS list if osx is.