Automapping Tile Objects #890
Conversation
Tile Objects can be added to Object Layers through the automapping mechanism. Also, fixed bug in "DeleteTiles" functionality with respect to Objects (tiled or otherwise).
|
@stefanbeller Do you have time to review this? |
|
|
||
| // Note: intersects returns false in some conditions so check if corners are contained | ||
| const QRect& objRect = obj->bounds().toAlignedRect(); | ||
| if (where.intersects(objRect) || where.contains(objRect.topLeft()) || where.contains(objRect.bottomLeft())) |
There was a problem hiding this comment.
Hmm, intersects should only return false if the intersection is empty. This happens also when either rectangle is empty, even though one is contained in the other. So, it should be enough to check only one corner (in addition to the intersects).
This reverts commit 5b7997f.
Map Objects are removed from automapping when "DeleteTiles" is used. Code was already there for this but was comparing tile space with map space. Tile Objects can be added to Object Layers through automapping. Tile Objects having a bottom-left origin and zero width and height was problematic for automapping. I've added a convenience function MapObject::boundsUseTile() that will use the tile, if present, to build the boundary for a given Tile Object. (Perhaps that function could be better named?) Note: it's possible that the added functionaliy of MapObject::boundsUseTile() could just be rolled into MapObject::bounds(), but I didn't want to (potentially) break legacy code that may have relied on Tile Objects having an empty bounds. For instance, do we want Tile Objects to be written out to TMX with non-zero width and height now?
|
I am putting together another pull request. Thanks for the feedback. |
|
I don't know what I'm doing with Github. :/ |
|
Not sure what's with that build failure. Is it because I had briefly closed the pull request? |
That's what the AppVeyor page indicates, yes. Nothing to worry about. |
| @@ -42,7 +43,22 @@ void eraseRegionObjectGroup(MapDocument *mapDocument, | |||
| // tile objects. polygons and polylines are not covered correctly by this | |||
There was a problem hiding this comment.
Does the comment here need updating?
There was a problem hiding this comment.
Hmm, it does not look like it to me, because it already says the correct thing is done for tile objects. The patch seems to make the comment more correct than before.
|
I've pushed this fix as commit 521a40a, thanks! |
|
Awesome. Thanks, Bjorn. On Sun, Mar 29, 2015 at 9:27 AM, Thorbjørn Lindeijer <
|
Tile Objects can be added to Object Layers through the automapping
mechanism.
Also, fixed bug in "DeleteTiles" functionality with respect to Objects
(tiled or otherwise).