Shim fd_sync #29
Merged
Shim fd_sync #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm happy to hear that this project has been helpful for you. Adding a nop fd_sync impl makes sense to me. The entire VFS is in-memory anyway. Maybe you could move it to I think fd_seek on a directory returns EBADF in Wasmtime however. |
Remove wasmtime-incompatible fd_seek implementation for dirs
|
Cool. I've done so. Also removed the incompatible |
|
Huh, turns out we didn't need the |
|
Released as v0.2.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, a huge thanks for creating this project. I have been using this for about a month with a few additions in a fairly large project (at work) and its been great. After the last few commits, only the remaining two changes are necessary to make it work.
The
fd_syncone is trivial. Forfd_seekon directories, IIUC the return value is supposed to be treated as an opaque value so I return 0 there.