return proper ERRNOs in OpenDirectory.path_open #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!☺️
I was trying to get a Python interpreter to run in the WASI shim and got weird errors like this:
After enabling
strace
and uncommenting theconsole.log
line, which prints thepath
, I found that the interpreter was trying to openpyvenv.cfg
andpybuilddir.txt
. Including those in the shimmed filesystem (even as empty files) allowed the interpreter to continue. However, the underlying problem is probably that the interpreter gets confused by the-1
return code on nonexistent files.Therefore, this commit uses the (I hope) appropriate ERRNOs in
OpenDirectory.path_open
, so the interpreter also works when those files do not exist in the filesystem.It is accompanied by another, functionally independent PR (#38), which shims
sock_accept
in the imports. Both are needed for Python to work.