Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made project more accessible to contributions #39

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

jsoverson
Copy link
Contributor

Thank you for this project @bjorn3!

This PR looks like a lot but has mostly cosmetic changes and is broken down into three commits:

  • Formatting:
    • Formatted code with prettier
    • Added .prettierrc configuration to prefer double quotes over single.
    • Added formatting validation to the check task
  • Linting/types
    • Added eslint and recommended TypeScript lints
    • Fixed lint errors (mostly let vs. const and unused variables)
    • Fixed issues where TypeScript typings were being ignored.
    • Added eslint to the check task
  • README/Demo:
    • Found the wasm-rustc tarball and archived the contents here. I can transfer that repo to you as it makes more sense here.
    • Added that repo as a git submodule
    • Added README documentation to show how to build the project and run the demo locally.

I can break this PR down into three separate PRs if necessary.

@jsoverson
Copy link
Contributor Author

@bjorn3 if the direction these commits are going in aligns with the project, I'd like to submit a couple more to add a browser test harness, integration tests, et al.

src/fs_core.ts Show resolved Hide resolved
src/fs_core.ts Outdated Show resolved Hide resolved
src/wasi.ts Show resolved Hide resolved
src/wasi.ts Show resolved Hide resolved
src/wasi.ts Show resolved Hide resolved
src/wasi.ts Outdated Show resolved Hide resolved
@bjorn3
Copy link
Owner

bjorn3 commented Oct 3, 2023

Thanks a lot! I've got a couple of points where I disagree with eslint, but overall this is great.

I can transfer that repo to you as it makes more sense here.

Sure

@jsoverson
Copy link
Contributor Author

I reverted the extracted functions and added a simple debug logger that is disabled by default.

examples/rustc.html Outdated Show resolved Hide resolved
src/wasi.ts Outdated Show resolved Hide resolved
@jsoverson jsoverson force-pushed the formatting branch 2 times, most recently from 7622d22 to 5879c2e Compare October 5, 2023 14:30
@jsoverson
Copy link
Contributor Author

@bjorn3 LMK if you need anything else for this PR.

Copy link
Owner

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this. If you don't mind could you do

I can transfer that repo to you as it makes more sense here.

first and update the submodule url before I merge?

@jsoverson
Copy link
Contributor Author

Started the repo transfer. LMK when you've accepted and I'll update the PR

@bjorn3
Copy link
Owner

bjorn3 commented Oct 9, 2023

Accepted the repo move.

@jsoverson
Copy link
Contributor Author

@bjorn3 thanks. I updated the relevant commit

@bjorn3 bjorn3 merged commit 4f69fae into bjorn3:main Oct 9, 2023
1 check passed
@bjorn3
Copy link
Owner

bjorn3 commented Nov 14, 2023

Released in v0.2.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants