feat: implement path_remove_directory and path_unlink_file system calls #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
|
We have tested the Would love to get some feedback on this approach. |
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
Prakhar-Agarwal-byte
force-pushed
the
path_remove_directory
branch
from
9f9923c
to
f8ac2ca
Compare
Signed-off-by: prakharagarwal1 <prakharagarwal3031@gmail.com>
Prakhar-Agarwal-byte
force-pushed
the
path_remove_directory
branch
from
f8ac2ca
to
d2bc625
Compare
Prakhar-Agarwal-byte
changed the title
|
@bjorn3 I have fixed the bug, its working fine now |
bjorn3
reviewed
Nov 21, 2023
src/fs_fd.ts
Outdated
| return wasi.ERRNO_NOENT; | ||
| } | ||
| if (entry.stat().filetype === wasi.FILETYPE_DIRECTORY) { | ||
| console.log("file is actually a directory"); |
There was a problem hiding this comment.
Please replace this and the other console.log below with debug.log or remove them entirely.
bjorn3
reviewed
Nov 21, 2023
src/fs_core.ts
Outdated
| @@ -122,6 +122,28 @@ export class Directory { | |||
| return entry; | |||
| } | |||
|
|
|||
| get_parent_dir_for_path( | |||
| path: string, | |||
| ): File | Directory | SyncOPFSFile | null { | |||
There was a problem hiding this comment.
This function can only return a Directory or null, right?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49
This adds support for the path_remove_directory and path_unlink_file system calls.