Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Setup wasi-testsuite with Node.js adapter #56

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

kateinoigakukun
Copy link
Contributor

@kateinoigakukun kateinoigakukun commented Dec 5, 2023

Based on #57

@bjorn3
Copy link
Owner

bjorn3 commented Dec 5, 2023

In #42 @jsoverson is working on adding testing in the browser using the wasi tests of the wasmtime test suite. How does wasi-testsuite relate to this? Either way I think testing in both node.js and a headless browser makes sense.

@kateinoigakukun
Copy link
Contributor Author

Currently wasi-testsuite is a part of test suite of wasmtime (https://github.com/bytecodealliance/wasmtime/tree/main/tests/wasi_testsuite). Compared with the wasmtime's their own test suite, It provides pre-compiled wasm-wasi binaries and test harness, so it's much simpler and easier. I think it's good starting point to avoid regression and see the project implementation status.

Copy link
Owner

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a single nit. In the future I would also like testing in an actual browser like #42 does, but testing in just node.js is already a big improvement.

.github/workflows/check.yml Outdated Show resolved Hide resolved
`examples/wasm-rustc` is not used while running the tests.
@bjorn3 bjorn3 merged commit 0426003 into bjorn3:main Dec 14, 2023
1 check passed
@bjorn3 bjorn3 mentioned this pull request Dec 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants