Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert the input range in joint limits setters #772

Merged
merged 1 commit into from
May 10, 2024
Merged

Assert the input range in joint limits setters #772

merged 1 commit into from
May 10, 2024

Conversation

jmiskovic
Copy link
Contributor

The Jolt already asserts these values, which results in segfault instead of helpful error message.

For cone joint the value out of range will now throw error instead of silent clamp.

@jmiskovic
Assert the input range in joint limits setters
09f106d 
The Jolt already asserts these values, which results in crash instead
of helpful error message.

For cone joint the value out of range will now throw error instead of
silent clamp.
@bjornbytes bjornbytes merged commit 4c6083e into bjornbytes:dev May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornbytes bjornbytes bjornbytes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmiskovic @bjornbytes