Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change babel config setup #385

Closed
wants to merge 1 commit into from

Conversation

megawac
Copy link

@megawac megawac commented Jun 26, 2019

This change is to support the updated babel config setup to support parsing the config in dependencies.

Currently if I try to use jsts with babel-7I'll get errors if I try to import anything in the org or java directories and use them in jest unit tests as they use es6 imports/exports (it seems to work with older versions of babel). This is because of this change here jestjs/jest#6053 (comment). Here is a big thread on the topic jestjs/jest#6229.

The simple fix is to just swap .babelrc to babel.config.js as in this MR. I've verified this works for the project I'm working on with a mirror of jsts.

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   62.63%   62.63%           
=======================================
  Files         279      279           
  Lines       14242    14242           
=======================================
  Hits         8920     8920           
  Misses       5322     5322

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ffd7ba...c43637a. Read the comment docs.

@bjornharrtell
Copy link
Owner

Thanks, read about it (superficially) and I think this change makes sense. But I want to evaluate a bit more before merging.

@megawac
Copy link
Author

megawac commented Jun 26, 2019

Sure no problem, let me know if you need anything from my end

@bjornharrtell
Copy link
Owner

Done with 20c2c88 but I target Node 10 instead.

@megawac megawac deleted the update-babel-config branch June 28, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants