fixes #24786 - fact importing after core refactor

app/models/foreman_chef/fact_importer.rb

@@ -16,93 +16,6 @@ def self.support_background
 
     private
 
-    attr_accessor :original_facts
-
-    def logger
-      Foreman::Logging.logger('foreman_chef')
-    end
-
-    def add_new_facts
-      @counters[:added] = 0
-      add_missing_facts(Sparser.new.unsparse(original_facts))
-      logger.debug("Merging facts for '#{host}': added #{@counters[:added]} facts")
-    end
-
-    def add_missing_facts(tree_hash, parent = nil, prefix = '')
-      tree_hash.each do |name, value|
-        name_with_prefix = prefix.empty? ? name : prefix + FactName::SEPARATOR + name
-
-        compose = value.is_a?(Hash)
-        if fact_names[name_with_prefix].present?
-          fact_name_id = fact_names[name_with_prefix]
-        else
-          # fact names didn't contain fact_name so we create new one
-          fact_name = fact_name_class.new(:name      => name_with_prefix,
-                                          :parent_id => parent,
-                                          :compose   => compose)
-          if fact_name.save
-            fact_name_id = fact_name.id
-          elsif fact_name.errors[:name].present?
-            # saving could have failed because of raise condition with another import process,
-            # so if the error is on name uniqueness, we try to reload conflicting name and use it
-            conflicting_fact_name = fact_name_class.where(:name => fact_name.name).first
-            fact_name_id = conflicting_fact_name.id
-          else
-            raise FactNameImportError, "unable to save fact name, errors: #{fact_name.errors.full_messages.join("\n")}"
-          end
-          fact_name_id
-        end
-
-        if compose
-          add_fact(name_with_prefix, nil, fact_name_id)
-          add_missing_facts(value, fact_name_id, name_with_prefix)
-        else
-          add_fact(name_with_prefix, value, fact_name_id)
-        end
-      end
-    end
-
-    def add_fact(name, value, fact_name_id)
-      if facts_to_create.include?(name)
-        host.fact_values.send(method,
-                              :value => value, :fact_name_id => fact_name_id)
-        @counters[:added] += 1
-      end
-    end
-
-    def facts_to_create
-      @facts_to_create ||= facts.keys - db_facts.pluck('fact_names.name')
-    end
-
-    def fact_names
-      @fact_names ||= fact_name_class.group(:name).maximum(:id)
-    end
-
-    # if the host does not exists yet, we don't have an host_id to use the fact_values table.
-    def method
-      @method ||= host.new_record? ? :build : :create!
-    end
-
-    def normalize(facts)
-      @original_facts = super(facts)
-      @facts = completify(@original_facts)
-    end
-
-    def completify(hash)
-      new_facts = hash.dup
-      hash.each do |fact_name, value|
-        name_parts = fact_name.split(FactName::SEPARATOR)
-
-        name_parts.inject([]) do |memo, name|
-          memo           = memo + [name]
-          key            = memo.join(FactName::SEPARATOR)
-          new_facts[key] ||= name_parts == memo ? value : nil
-          memo
-        end
-      end
-      new_facts
-    end
-
     class Sparser
       def sparse(hash, options={})
         hash.map do |k, v|