Skip to content

Commit

Permalink
Fix version bounds in .cabal files
Browse files Browse the repository at this point in the history
  • Loading branch information
andreasabel committed Jan 6, 2022
1 parent 4393e7d commit 723c0fa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion language-python-test/language-python-test.cabal
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: language-python-test
version: 0.5.8
cabal-version: >= 1.6
cabal-version: >= 1.8
synopsis: testing code for the language-python library
description: testing code for the language-python library
category: Language
Expand Down
6 changes: 3 additions & 3 deletions language-python/language-python.cabal
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: language-python
version: 0.5.8
cabal-version: >= 1.6
cabal-version: >= 1.8
synopsis: Parsing and pretty printing of Python code.
description: language-python is a Haskell library for lexical analysis, parsing
and pretty printing Python code. It supports versions 2.x and 3.x of Python.
Expand All @@ -23,11 +23,11 @@ Library
hs-source-dirs: src
ghc-options: -fwarn-incomplete-patterns -fwarn-unused-imports -fwarn-warnings-deprecations
build-depends:
base == 4.*,
base >= 4.8 && < 5,
containers >= 0.5 && < 0.7,
pretty == 1.1.*,
array >= 0.4 && < 0.6,
transformers >= 0.3 && < 0.6,
transformers >= 0.3 && < 0.7,

This comment has been minimized.

Copy link
@andreasabel

andreasabel Jun 17, 2023

Author Contributor

I should not have done this relaxation, since transformers-0.6 is blocked by monads-tf, thus, this relaxation is basically untested.

monads-tf == 0.1.*,
utf8-string >= 1 && < 2
build-tools: happy, alex
Expand Down

2 comments on commit 723c0fa

@bjpop
Copy link
Owner

@bjpop bjpop commented on 723c0fa Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @andreasabel

Please advise how you think we should proceed when you have a chance.

@andreasabel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the point is that monads-tf should be updated to transformers-0.6 so that the latter can actually be used for building. (Then, setting the upper bound to <0.7 is justified, as it is tested.)

Upstream issue is here: commercialhaskell/stackage#6857

Atm, it is up to Ross Paterson to release an update for monads-tf.

Please sign in to comment.