Remove deprecated doctrine #90
Conversation
Adding an option to set the object manager.
|
@jhuet this PR is not based on current master... Did you update your fork before starting it? |
| if (! isset($config['bjyauthorize']['role_providers']['BjyAuthorize\Provider\Role\Doctrine']['role_entity_class'])) { | ||
| throw new InvalidArgumentException('role_entity_class not set in the bjyauthorize role_providers config.'); | ||
| } | ||
| $roleClass = $config['bjyauthorize']['role_providers']['BjyAuthorize\Provider\Role\Doctrine']['role_entity_class']; |
There was a problem hiding this comment.
Keep empty newlines between code blocks with different meaning and grouped assignment blocks
|
Looks good so far! Git screwed up a couple of diffs, but that's not your fault :) You need a rebase anyway. Also, squash it into a single commit. TODOs:
|
…ion-strategy-cleanup Feature/redirection strategy cleanup
…gration First implementation of the ZendDeveloperToolbar integration
|
Sorry, I didn't manage to understand - it this PR should bring the mongodb integration into this module, or make sure there isn't any doctrine orm specific code in it so you could use mongodb without any custom code ? |
|
@dorongutman this PR removes ORM-specific hinting and old code that was deprecated. The doctrine integration was already compatible with MongoDB ODM. |
|
@Ocramius so even though the current status' docs (before this PR) explains that I need to use the |
|
@dorongutman correct |
|
@jhuet I'm overtaking this one as soon as I get home: we'll get back to 0 issues hopefully =) |
Adding an option to set the object manager.
…orize into remove-deprecated-doctrine Conflicts: config/services.config.php
|
Hmmm i just wanted to do a rebase so you could take over, but i kinda fucked up here :D I guess it's till working though. |
|
@jhuet np, I'll try to recover :) |
|
I started working on master...cleanup;doctrine Will close as soon as I have a new PR ready |
|
Closing, see #96 |
In order to fix #89.
It's an early PR open to suggestions. As of now it should work on its own, here's what i did :
Entity(as it's also usable for documents)I didn't change tests though.