ControlService: added possibility to manage the VNC under the control of another apps #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of another apps bk138#83 allows any other application that has been given the "net.christianbeier.droidvnc_ng.VNC_IPC_CONTROL" permissions to send intends to start a VNC session in listening/reverse or repeater mode
bk138
reviewed
May 18, 2022
…olService to MainService bk138#84
…nt if they are part of the intent
|
Hello Christian, |
|
Oh, I didn't know it was ready. I'll review time permitting (rather busy this week). |
bk138
requested changes
Jun 5, 2022
app/src/main/java/net/christianbeier/droidvnc_ng/MainService.java
Outdated
Show resolved
Hide resolved
app/src/main/java/net/christianbeier/droidvnc_ng/MainService.java
Outdated
Show resolved
Hide resolved
go away from different types of intents and only use the "start" intent to start any type of VNC connection -Read/write settings moved away from MainService. Settings are always a part of the start intent EXTRAS
moved retrieval of network information from MainService to MainActivity
… on the running server bk138#84 stop the existing VNC server instance and start a new one only if both PORT and HOST extras are set. So we can start reverse and repeater connections using the current VNC server instance
…8#84 stop MainService and don't try to start a repeater or a reverse connection if no instance of VNC server is running
|
Thanks for the changes. Will take some time to review as I'm busy with €€€ work this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows any other application that has been given the "net.christianbeier.droidvnc_ng.VNC_IPC_CONTROL" permissions to send intends to start a VNC session in listening/reverse or repeater mode