Skip to content

Commit

Permalink
delta-islands.c: remove the_repository references
Browse files Browse the repository at this point in the history
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
pclouds authored and gitster committed Nov 12, 2018
1 parent c207e9e commit 385cb64
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 15 deletions.
4 changes: 2 additions & 2 deletions builtin/pack-objects.c
Expand Up @@ -2628,7 +2628,7 @@ static void prepare_pack(int window, int depth)
unsigned n;

if (use_delta_islands)
resolve_tree_islands(progress, &to_pack);
resolve_tree_islands(the_repository, progress, &to_pack);

get_object_details();

Expand Down Expand Up @@ -3143,7 +3143,7 @@ static void get_object_list(int ac, const char **av)
return;

if (use_delta_islands)
load_delta_islands();
load_delta_islands(the_repository);

if (prepare_revision_walk(&revs))
die(_("revision walk setup failed"));
Expand Down
24 changes: 14 additions & 10 deletions delta-islands.c
Expand Up @@ -190,13 +190,15 @@ static void set_island_marks(struct object *obj, struct island_bitmap *marks)
island_bitmap_or(b, marks);
}

static void mark_remote_island_1(struct remote_island *rl, int is_core_island)
static void mark_remote_island_1(struct repository *r,
struct remote_island *rl,
int is_core_island)
{
uint32_t i;

for (i = 0; i < rl->oids.nr; ++i) {
struct island_bitmap *marks;
struct object *obj = parse_object(the_repository, &rl->oids.oid[i]);
struct object *obj = parse_object(r, &rl->oids.oid[i]);

if (!obj)
continue;
Expand All @@ -211,7 +213,7 @@ static void mark_remote_island_1(struct remote_island *rl, int is_core_island)
while (obj && obj->type == OBJ_TAG) {
obj = ((struct tag *)obj)->tagged;
if (obj) {
parse_object(the_repository, &obj->oid);
parse_object(r, &obj->oid);
marks = create_or_get_island_marks(obj);
island_bitmap_set(marks, island_counter);
}
Expand All @@ -237,7 +239,9 @@ static int tree_depth_compare(const void *a, const void *b)
return todo_a->depth - todo_b->depth;
}

void resolve_tree_islands(int progress, struct packing_data *to_pack)
void resolve_tree_islands(struct repository *r,
int progress,
struct packing_data *to_pack)
{
struct progress *progress_state = NULL;
struct tree_islands_todo *todo;
Expand Down Expand Up @@ -281,7 +285,7 @@ void resolve_tree_islands(int progress, struct packing_data *to_pack)

root_marks = kh_value(island_marks, pos);

tree = lookup_tree(the_repository, &ent->idx.oid);
tree = lookup_tree(r, &ent->idx.oid);
if (!tree || parse_tree(tree) < 0)
die(_("bad tree object %s"), oid_to_hex(&ent->idx.oid));

Expand All @@ -292,7 +296,7 @@ void resolve_tree_islands(int progress, struct packing_data *to_pack)
if (S_ISGITLINK(entry.mode))
continue;

obj = lookup_object(the_repository, entry.oid->hash);
obj = lookup_object(r, entry.oid->hash);
if (!obj)
continue;

Expand Down Expand Up @@ -415,7 +419,7 @@ static struct remote_island *get_core_island(void)
return NULL;
}

static void deduplicate_islands(void)
static void deduplicate_islands(struct repository *r)
{
struct remote_island *island, *core = NULL, **list;
unsigned int island_count, dst, src, ref, i = 0;
Expand Down Expand Up @@ -444,20 +448,20 @@ static void deduplicate_islands(void)
core = get_core_island();

for (i = 0; i < island_count; ++i) {
mark_remote_island_1(list[i], core && list[i]->hash == core->hash);
mark_remote_island_1(r, list[i], core && list[i]->hash == core->hash);
}

free(list);
}

void load_delta_islands(void)
void load_delta_islands(struct repository *r)
{
island_marks = kh_init_sha1();
remote_islands = kh_init_str();

git_config(island_config_callback, NULL);
for_each_ref(find_island_for_ref, NULL);
deduplicate_islands();
deduplicate_islands(r);

fprintf(stderr, _("Marked %d islands, done.\n"), island_counter);
}
Expand Down
9 changes: 6 additions & 3 deletions delta-islands.h
@@ -1,14 +1,17 @@
#ifndef DELTA_ISLANDS_H
#define DELTA_ISLANDS_H

struct commit;
struct object_id;
struct packing_data;
struct commit;
struct repository;

int island_delta_cmp(const struct object_id *a, const struct object_id *b);
int in_same_island(const struct object_id *, const struct object_id *);
void resolve_tree_islands(int progress, struct packing_data *to_pack);
void load_delta_islands(void);
void resolve_tree_islands(struct repository *r,
int progress,
struct packing_data *to_pack);
void load_delta_islands(struct repository *r);
void propagate_island_marks(struct commit *commit);
int compute_pack_layers(struct packing_data *to_pack);

Expand Down

0 comments on commit 385cb64

Please sign in to comment.