Skip to content

Commit

Permalink
column: drop unused "opts" parameter in item_length()
Browse files Browse the repository at this point in the history
There are no column options which impact the length computation. In
theory there might be, but this is a file-local function, so it will be
trivial to re-add the parameter should it ever be useful.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
peff authored and gitster committed Jan 24, 2019
1 parent fcb133e commit acbf33f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions column.c
Expand Up @@ -21,7 +21,7 @@ struct column_data {
};

/* return length of 's' in letters, ANSI escapes stripped */
static int item_length(unsigned int colopts, const char *s)
static int item_length(const char *s)
{
int len, i = 0;
struct strbuf str = STRBUF_INIT;
Expand Down Expand Up @@ -167,7 +167,7 @@ static void display_table(const struct string_list *list,

ALLOC_ARRAY(data.len, list->nr);
for (i = 0; i < list->nr; i++)
data.len[i] = item_length(colopts, list->items[i].string);
data.len[i] = item_length(list->items[i].string);

layout(&data, &initial_width);

Expand Down

0 comments on commit acbf33f

Please sign in to comment.