Skip to content

Commit

Permalink
Make build fail fast if meta image build fails or there's no binary i…
Browse files Browse the repository at this point in the history
…mage
  • Loading branch information
bkabrda committed Jul 23, 2015
1 parent b9b73dd commit 5988bdd
Showing 1 changed file with 15 additions and 13 deletions.
28 changes: 15 additions & 13 deletions atomicapp_builder/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,31 +121,33 @@ def build(args):
res = bldr.build()
if not res:
func_result = 1
break # fail fast
for l in a.meta_image.build_result.build_logs:
logger.debug(l)
logger.info('{doing} meta image "{mi}" for app "{app}" {result}.'.
format(doing=doing_what, mi=a.meta_image.imagename, app=a.appid,
result='succeeded' if res else 'failed')
)
if args['check_binary_images']:
func_result = func_result or _check_binary_images(apps)
if args['check_binary_images']:
func_result = _check_binary_images(a)
if func_result:
break # fail fast

if args['keep_tmpdir']:
logger.info('You can find sources of all apps in {0}'.format(tmpdir))

return func_result


def _check_binary_images(apps):
res = 0
for app in apps:
logger.info('Checking for binary images required for app "{0}" ...'.format(app.appid))
for bi in app.binary_images:
if bi.built:
logger.info('Binary image "{0}" exists.'.format(bi.imagename))
else:
logger.error('Binary image "{0}" doesn\'t exist'.format(bi.imagename))
res = 2
return res
def _check_binary_images(app):
logger.info('Checking for binary images required for app "{0}" ...'.format(app.appid))
for bi in app.binary_images:
if bi.built:
logger.info('Binary image "{0}" exists.'.format(bi.imagename))
else:
logger.error('Binary image "{0}" doesn\'t exist'.format(bi.imagename))
return 2
return 0


class TempDir(object):
Expand Down

0 comments on commit 5988bdd

Please sign in to comment.