-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added support for larger varint's (Potential fix for #19)
- Loading branch information
Showing
1 changed file
with
18 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff421ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you miss the line 251
client->audio_sequence = (client->audio_sequence + 1) % 1000;
on purpose here?ff421ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did, this is just a more complex fix for the issue. This bit of code allows it to write a number above the value 0x4000, which audio_sequence is doing. Setting it to
1000
is just a more simple fix. :Pff421ab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use a similar value in my LuaJit/FFI implementation of this module which fully implements mumble varint's as well, and I've had audio playing for hours on end without issue.
https://github.com/bkacjios/Lumble/blob/a56ac08e81ee9634cbcab2d89a240f108f7c910b/modules/lumble/client/init.lua#L750
https://github.com/bkacjios/Lumble/blob/a56ac08e81ee9634cbcab2d89a240f108f7c910b/modules/buffer.lua#L231
This is basically just a backport.