-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting specific WindowsPlatform #147
Comments
I'll add option 2, 3. |
TheJare
added a commit
to TheJare/bgfx-rs
that referenced
this issue
Apr 15, 2017
bkaradzic
added a commit
that referenced
this issue
Apr 15, 2017
pigpigyyy
added a commit
to pigpigyyy/bx
that referenced
this issue
Apr 24, 2017
* master: Cleanup. Renaming string functions. Fixed issue bkaradzic#149. Cleanup. GENie 813. Renaming string functions. Updated toolchain for specifying Windows SDK version. Issue bkaradzic#147. Fixed Emscripten 1.37.9 build. GENie 811. Fixed include. assume LLVM libc++ if __llvm__ is defined but __GLIBC__ is undefined (bkaradzic#145) Trying to fix GitHub detecting licesnse. Cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The toolchain script currently only allows configuring the windowsTargetPlatformVersion project setting if the toolset target is set to "--vs=winstore82". Otherwise the project setting will default to 8.1. It seems this parameter should be settable always. Three suggestions (can't make a pull request right now):
Move the 3 lines that assign the platform, from the "winstore82" subsection up to the enclosing if, right before starting to check specific "--vs" toolsets.
Allow a smarter default for the "--with-windows" argument that sets the "windowsPlatform" variable, based on the standard environment variable "WindowsSDKVersion", and in its absence, default to a more conservative platform of 8.1.
Perhaps the various toolsets may enforce higher values for this setting, so for example if requesting winstore82 then convert 8.1 into the previous default of 10.0.10240.0
Update the newoption for with-windows to describe the new default more accurately.
The text was updated successfully, but these errors were encountered: